roles: changed need creation by role name to id #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
approved these changes
Aug 1, 2023
|
With tests failing, we might not be able to release this. It looks like that we might have to pin |
Seems to be the option, I think we already had to do it in other modules due to the deprecation of ping @zzacharo |
ntarocco
force-pushed
the
refactor_roleneed_roleid
branch
from
4b08d17 to
5125ba0
Compare
|
We will need to check this together before merging. |
jrcastro2
force-pushed
the
refactor_roleneed_roleid
branch
from
f195738 to
87924e5
Compare
jrcastro2
force-pushed
the
refactor_roleneed_roleid
branch
from
87924e5 to
eff9930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes inveniosoftware/invenio-access#205